dybyte commented on code in PR #10223:
URL: https://github.com/apache/seatunnel/pull/10223#discussion_r2648363177
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/checkpoint/CheckpointCoordinator.java:
##########
@@ -287,6 +289,25 @@ private void handleCoordinatorError(CheckpointCloseReason
reason, Throwable e) {
if (checkpointCoordinatorFuture.isDone()) {
return;
}
+
+ int failedCount = consecutiveFailedCounter.incrementAndGet();
+ int tolerableFailures =
coordinatorConfig.getCheckpointTolerableFailed();
+
+ if (tolerableFailures > 0 && failedCount <= tolerableFailures) {
+ LOG.warn(
+ "Checkpoint failed (consecutive failures: {}/{}): {}",
+ failedCount,
+ tolerableFailures,
+ ExceptionUtils.getMessage(checkpointException));
+ cleanFailedCheckpoint(reason);
+ return;
+ }
Review Comment:
What happens if a checkpoint fails during a savepoint operation? Is there a
possibility that the job could stop progressing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
