dybyte commented on code in PR #10208:
URL: https://github.com/apache/seatunnel/pull/10208#discussion_r2650242600
##########
seatunnel-translation/seatunnel-translation-flink/seatunnel-translation-flink-common/src/main/java/org/apache/seatunnel/translation/flink/source/FlinkSource.java:
##########
@@ -91,21 +93,25 @@ public SourceReader<SeaTunnelRow, SplitWrapper<SplitT>>
createReader(
@Override
public SplitEnumerator<SplitWrapper<SplitT>, EnumStateT> createEnumerator(
SplitEnumeratorContext<SplitWrapper<SplitT>> enumContext) throws
Exception {
+ Set<Integer> noMoreSplitsSignaledReaders =
ConcurrentHashMap.newKeySet();
SourceSplitEnumerator.Context<SplitT> context =
- new FlinkSourceSplitEnumeratorContext<>(enumContext);
+ new FlinkSourceSplitEnumeratorContext<>(
+ enumContext, noMoreSplitsSignaledReaders::add);
SourceSplitEnumerator<SplitT, EnumStateT> enumerator =
source.createEnumerator(context);
- return new FlinkSourceEnumerator<>(enumerator, enumContext);
+ return new FlinkSourceEnumerator<>(enumerator, enumContext,
noMoreSplitsSignaledReaders);
}
@Override
public SplitEnumerator<SplitWrapper<SplitT>, EnumStateT> restoreEnumerator(
SplitEnumeratorContext<SplitWrapper<SplitT>> enumContext,
EnumStateT checkpoint)
throws Exception {
+ Set<Integer> noMoreSplitsSignaledReaders =
ConcurrentHashMap.newKeySet();
Review Comment:
Could you explain why a new set is created when restoring the enumerator?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
