yzeng1618 commented on PR #10251:
URL: https://github.com/apache/seatunnel/pull/10251#issuecomment-3696037444

   > Is it enough to just have `HiveOption`? Moreover, HiveConfig now 
implements the functions of `Option`. I think they can all be moved to 
`HiveOption`.
   
   HiveConfig is already the single source of truth; HiveOptions is just a thin 
compatibility wrapper inheriting FileBaseSourceOptions. Moving everything into 
HiveOptions would leak file-source semantics into sink/other paths and still 
wouldn’t cover items like HADOOP_CONF or ABORT_DROP_PARTITION_METADATA. Better 
path: keep options in HiveConfig, migrate callers to it, and deprecate 
HiveOptions later rather than shifting definitions over.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to