chl-wxp commented on PR #10252: URL: https://github.com/apache/seatunnel/pull/10252#issuecomment-3697997803
> > > JdbcPostgresIT should not be closed. The focus of the e2e module and the unit test module are different. The process of the main test tasks of e2e > > > > > > Hi @chl-wxp, thank you for the feedback. I will restore the JdbcPostgresIT in the E2E module immediately. Regarding the PostgresDialect tests, I had also disabled them while moving the logic to the new container-based tests. Would you like me to restore those as well to maintain the original coverage, keeping the new tests as a complement? > > 1. I think it is necessary for me to talk about the difference between e2e and unit testing. e2e mainly focuses on submitting seatunnel task process tests, while unit testing focuses on the correctness of internal logic. I mentioned before that I wanted to move the unit tests in the e2e module because the previous code had been written in the wrong location. For example, the unit test in the screenshot below should not appear in e2e. > 2. There is no need to delete or close the old unit tests in the connector. You can add or modify them based on the original PostgresDialect unit tests. Our ultimate goal is to successfully automate the test when the completed code is submitted. <img width="1472" height="991" alt="image" src="https://github.com/user-attachments/assets/2ecb1ae6-499e-47e3-abdc-c08a7f7f2df6"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
