yzeng1618 commented on code in PR #10232:
URL: https://github.com/apache/seatunnel/pull/10232#discussion_r2654821858
##########
seatunnel-core/seatunnel-flink-starter/seatunnel-flink-starter-common/src/main/java/org/apache/seatunnel/core/starter/flink/args/FlinkCommandArgs.java:
##########
@@ -53,6 +53,13 @@ public class FlinkCommandArgs extends AbstractCommandArgs {
+ "kubernetes-session, yarn-application,
kubernetes-application]")
private MasterType masterType;
+ /** restore checkpoint path */
+ @Parameter(
+ names = {"-s", "--fromSavepoint"},
+ description =
+ "Path to a savepoint to restore the job from (for example,
flink run -s
hdfs:///flink/checkpoints/3c298a925d9a2a7837bbf5a8e4966b4f/chk-7902).")
Review Comment:
The example describes a checkpoint, which is also inconsistent
##########
seatunnel-core/seatunnel-flink-starter/seatunnel-flink-starter-common/src/main/java/org/apache/seatunnel/core/starter/flink/args/FlinkCommandArgs.java:
##########
@@ -53,6 +53,13 @@ public class FlinkCommandArgs extends AbstractCommandArgs {
+ "kubernetes-session, yarn-application,
kubernetes-application]")
private MasterType masterType;
+ /** restore checkpoint path */
Review Comment:
The comment is inconsistent with the actual description of the savepoint
parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
