chl-wxp commented on PR #10266: URL: https://github.com/apache/seatunnel/pull/10266#issuecomment-3709459225
This looks functionally redundant with the existing SaveMode design. For file connectors, SeaTunnel already has: `DataSaveMode` to control how existing data (files) is handled `SchemaSaveMode` to control how the target path / directory is handled File existence is a data-level concern and should be covered by DataSaveMode. Introducing a separate file_exists_mode duplicates this responsibility and fragments behavior control, making the File connector inconsistent with other sinks. It would be preferable to reuse or extend the existing SaveMode mechanism rather than adding a new, connector-specific option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
