davidzollo commented on PR #10290:
URL: https://github.com/apache/seatunnel/pull/10290#issuecomment-3714795149
**Changes Requested**
Thanks for the contribution. The refactoring of `joinRows` looks good, but
there are a few critical issues that need to be addressed before merging:
1. **Logic Inversion**: The logic for `wrap_json_as_array` seems inverted.
* Currently: `if (!sinkConfig.isSinkWrapJsonAsArray())` triggers the
wrapping logic. Since the default is `false`, `!false` is `true`, so it wraps
by default.
* **Issue**: If a user sets `wrap_json_as_array = true`, the code
enters the `else` block (no wrapping). This is counter-intuitive.
* **Suggestion**: Rename it to something like
`enable_json_array_wrapping` (default `true`) or invert the `if` condition to
match the current name semantics.
2. **Missing Tests**: Please add unit tests in
`StarRocksStreamLoadVisitorTest` to verify that the output format is correct
when the option is enabled vs. disabled.
3. **PR Title**: This change affects the `Sink`, not the `Source`. Please
update the PR title to `[Improve][Connector-V2][starrocks-sink]...`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
