liugddx commented on code in PR #10273:
URL: https://github.com/apache/seatunnel/pull/10273#discussion_r2670660219
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/rest/service/BaseService.java:
##########
@@ -355,11 +406,52 @@ private void processMetric(
String metricName,
String tableName,
JsonNode metricNode,
- Map<String, JsonNode>[] tableMetricsMaps) {
+ Map<String, JsonNode>[] tableMetricsMaps,
+ Map<String, java.util.List<String>> tableToSinkIdentifiersMap) {
if (metricNode == null) {
return;
}
+ java.util.List<String> sinkIdentifiers =
tableToSinkIdentifiersMap.get(tableName);
Review Comment:
```suggestion
List<String> sinkIdentifiers =
tableToSinkIdentifiersMap.get(tableName);
```
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/rest/service/BaseService.java:
##########
@@ -374,30 +466,43 @@ private void processMetric(
SINK_BYTES_SEC_IDX = 10,
SINK_COMMITTED_BYTES_SEC_IDX = 11;
if (metricName.startsWith(SOURCE_RECEIVED_COUNT + "#")) {
- tableMetricsMaps[SOURCE_COUNT_IDX].put(tableName, metricNode);
+ tableMetricsMaps[SOURCE_COUNT_IDX].put(metricKey, metricNode);
} else if (metricName.startsWith(SINK_WRITE_COUNT + "#")) {
- tableMetricsMaps[SINK_COUNT_IDX].put(tableName, metricNode);
+ tableMetricsMaps[SINK_COUNT_IDX].put(metricKey, metricNode);
} else if (metricName.startsWith(SINK_COMMITTED_COUNT + "#")) {
- tableMetricsMaps[SINK_COMMITTED_COUNT_IDX].put(tableName,
metricNode);
+ tableMetricsMaps[SINK_COMMITTED_COUNT_IDX].put(metricKey,
metricNode);
} else if (metricName.startsWith(SOURCE_RECEIVED_BYTES + "#")) {
- tableMetricsMaps[SOURCE_BYTES_IDX].put(tableName, metricNode);
+ tableMetricsMaps[SOURCE_BYTES_IDX].put(metricKey, metricNode);
} else if (metricName.startsWith(SINK_WRITE_BYTES + "#")) {
- tableMetricsMaps[SINK_BYTES_IDX].put(tableName, metricNode);
+ tableMetricsMaps[SINK_BYTES_IDX].put(metricKey, metricNode);
} else if (metricName.startsWith(SINK_COMMITTED_BYTES + "#")) {
- tableMetricsMaps[SINK_COMMITTED_BYTES_IDX].put(tableName,
metricNode);
+ tableMetricsMaps[SINK_COMMITTED_BYTES_IDX].put(metricKey,
metricNode);
} else if (metricName.startsWith(SOURCE_RECEIVED_QPS + "#")) {
- tableMetricsMaps[SOURCE_QPS_IDX].put(tableName, metricNode);
+ tableMetricsMaps[SOURCE_QPS_IDX].put(metricKey, metricNode);
} else if (metricName.startsWith(SINK_WRITE_QPS + "#")) {
- tableMetricsMaps[SINK_QPS_IDX].put(tableName, metricNode);
+ tableMetricsMaps[SINK_QPS_IDX].put(metricKey, metricNode);
} else if (metricName.startsWith(SINK_COMMITTED_QPS + "#")) {
- tableMetricsMaps[SINK_COMMITTED_QPS_IDX].put(tableName,
metricNode);
+ tableMetricsMaps[SINK_COMMITTED_QPS_IDX].put(metricKey,
metricNode);
} else if (metricName.startsWith(SOURCE_RECEIVED_BYTES_PER_SECONDS +
"#")) {
- tableMetricsMaps[SOURCE_BYTES_SEC_IDX].put(tableName, metricNode);
+ tableMetricsMaps[SOURCE_BYTES_SEC_IDX].put(metricKey, metricNode);
} else if (metricName.startsWith(SINK_WRITE_BYTES_PER_SECONDS + "#")) {
- tableMetricsMaps[SINK_BYTES_SEC_IDX].put(tableName, metricNode);
+ tableMetricsMaps[SINK_BYTES_SEC_IDX].put(metricKey, metricNode);
} else if (metricName.startsWith(SINK_COMMITTED_BYTES_PER_SECONDS +
"#")) {
- tableMetricsMaps[SINK_COMMITTED_BYTES_SEC_IDX].put(tableName,
metricNode);
+ tableMetricsMaps[SINK_COMMITTED_BYTES_SEC_IDX].put(metricKey,
metricNode);
+ }
+ }
+
+ private String extractSinkIdentifier(String vertexName) {
+ if (vertexName == null) {
+ return "";
+ }
+
+ Pattern pattern =
Pattern.compile("((?:Sink|Source|Transform)\\[\\d+\\])");
Review Comment:
It is not recommended to put the `Pattern` inside the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
