LiJie20190102 commented on code in PR #10315:
URL: https://github.com/apache/seatunnel/pull/10315#discussion_r2678524778
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/CoordinatorService.java:
##########
@@ -771,13 +771,6 @@ public PassiveCompletableFuture<Void> cancelJob(long
jobId) {
CompletableFuture.supplyAsync(
() -> {
runningJobMaster.cancelJob();
- // The pending task "JobMaster.init" has not
been executed, so the
- // job status (JobStatus) will not be stored
in the
- // jobHistoryService. Here, storeJobEndState
is called to store the
- // `CANCELED` status in the jobHistoryService.
- if (isPendingJob) {
Review Comment:
For other runtime states, will this issue occur when canceling tasks, such
as `FAILING` and `DOING_SAVEPOINT`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
