zhangshenghang commented on PR #10334: URL: https://github.com/apache/seatunnel/pull/10334#issuecomment-3754993457
<!-- code-pr-reviewer --> Thanks for contributing this option! **CRITICAL: Missing docs for `require-replica-identity-full`** The connector docs currently mandate `REPLICA IDENTITY FULL` for all tables, contradicting the new option. Users who disable this in non-append-only scenarios will get incomplete UPDATE/DELETE events (missing before state), leading to data inconsistency that is difficult to debug in production. Please update the Source Options table with: - Type: Boolean, Default: true - Clear warning that `false` is only for append-only tables (e.g., outbox pattern) - Note that UPDATE/DELETE events may lack previous state when disabled **MAJOR: Improve config description** `PostgresOptions.java:56` should clarify usage constraints: > "Require the table to have REPLICA IDENTITY FULL. When set to false, allows tables with other replica identity settings, but UPDATE/DELETE events may not contain the previous state. This should only be used for append-only tables (e.g., outbox pattern). Default is true for backward compatibility." **MAJOR: Add test coverage** `PostgresDialect.java:131-141` (new conditional logic) lacks unit tests—please verify both `true`/`false` branches with mocked `PostgresConnection`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
