zhangshenghang commented on PR #10340: URL: https://github.com/apache/seatunnel/pull/10340#issuecomment-3755103407
<!-- code-pr-reviewer --> Thanks for contributing! 4 blocking issues must be addressed: **1. Missing plugin mapping** — `plugin-mapping.properties` lacks Oscar registration, preventing runtime discovery. Add: ``` connector-jdbc--Oscar=org.apache.seatunnel.connectors.seatunnel.jdbc.internal.dialect.oscar.OscarDialectFactory ``` **2. IndexOutOfBoundsException** — `OscarCatalog.listTables()` calls `databases.get(0)` without empty check. Validate before accessing. **3. Incompatible Upsert SQL** — Uses MySQL's `ON DUPLICATE KEY UPDATE`; Oscar (Oracle-derived) typically requires `MERGE INTO`. Verify docs and implement correct syntax or throw `UnsupportedOperationException`. **4. Wrong log constant** — `OscarTypeConverter.java:444` logs `MAX_SCALE` instead of `MAX_TIME_SCALE` for TIME precision issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
