zhangshenghang commented on PR #10342:
URL: https://github.com/apache/seatunnel/pull/10342#issuecomment-3755143367
<!-- code-pr-reviewer -->
Thanks for working on this.
**Blockers found - needs changes before merge**
1. Missing JAR dependencies notice (CRITICAL)
- `docs/en/engines/zeta/separated-cluster-deployment.md:290-311`
S3/MinIO config lacks required JAR dependencies notice while OSS example
has one. Users will encounter `ClassNotFoundException` and cluster fails to
initialize.
2. Ambiguous endpoint placeholder syntax (CRITICAL)
- `docs/en/engines/zeta/separated-cluster-deployment.md:306`
Using `http[s]://` placeholder is confusing; users may copy it verbatim
causing `UnknownHostException`. Provide explicit example like
`http://your-minio-endpoint:port` instead.
3. Inconsistent authentication property format (CRITICAL)
- `docs/en/engines/zeta/hybrid-cluster-deployment.md:364-365`
Clarify whether these follow Hadoop S3A standard properties to avoid
`AuthenticationException`.
4. Typo: Compatable → Compatible (MAJOR)
- `docs/en/engines/zeta/separated-cluster-deployment.md:290` and
`hybrid-cluster-deployment.md:346`
5. Quote inconsistency on boolean value (MAJOR)
- `docs/en/engines/zeta/separated-cluster-deployment.md:307`
Use `true` without quotes for consistency with other docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
