zhangshenghang commented on PR #10346:
URL: https://github.com/apache/seatunnel/pull/10346#issuecomment-3755197749
<!-- code-pr-reviewer -->
LGTM - this PR correctly fixes the nested curly braces regex for Redis
custom key placeholders, and the test coverage is adequate for the core
scenarios.
All verified issues are MINOR and non-blocking. The regex change from
`(?<!\$)\{([^}]+)\}` to `(?<!\$)\{([^{}]+)\}` properly resolves incorrect
matching in cases like `{{id}}`, and the new tests confirm the expected
behavior for both legacy and standard placeholder formats.
Future PRs could add edge case tests (null values, missing fields,
three-level braces, mixed formats), but the current implementation handles
these correctly based on existing code in `RedisSinkWriter.java:140-148`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
