yzeng1618 commented on PR #10331: URL: https://github.com/apache/seatunnel/pull/10331#issuecomment-3758520752
> Thanks for the fix! The core logic is correct with good unit test coverage. However, there are 2 blocking issues: > > **1. Missing E2E test for ORC format** (GEN-002 - MAJOR) > > * `HiveSourceConfig.java` modifies ORC empty file handling logic > * `HiveIT.java:105-131` only adds E2E tests for TEXT and PARQUET (`CREATE_EMPTY_TEXT_SQL`, `CREATE_EMPTY_PARQUET_SQL`) > * Missing `CREATE_EMPTY_ORC_SQL`, test method, and config file > * **Impact**: ORC branch changes lack end-to-end validation, regression risk exists > > **2. Code duplication in empty file fallback** (GEN-001 - MAJOR) > > * `HiveSourceConfig.java:301-307` (parseCatalogTable): TEXT/PARQUET/ORC branches all call identical `buildCatalogTableFromHiveMeta(readonlyConfig, table)` when `fileNames.isEmpty()` > * **Impact**: Future schema behavior changes require syncing 3 locations, easy to miss and cause inconsistencies > > Please add the ORC E2E test case. For the duplication issue, consider extracting a unified method like `handleEmptyFilesFallback(readonlyConfig, table)` as a follow-up improvement. > > Note: The reported P0 concurrency issue (COR-001) was marked UNVERIFIED - insufficient evidence in the diff to confirm. The repair has been completed as required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
