DanielCarter-stack commented on PR #10349: URL: https://github.com/apache/seatunnel/pull/10349#issuecomment-3759058650
<!-- code-pr-reviewer --> Thanks for the contribution. A few issues to address: **DatabendSinkAggregatedCommitter.java:257-258** - The outer `catch (SQLException e)` cannot catch `DatabendConnectorException` (a `RuntimeException`) from `performMerge()`. Remove or change to `Exception`. **DatabendSinkAggregatedCommitter.java:141-144** - The `aggregatedCommitInfos` parameter in `performMerge()` is unused beyond the null check. Remove this unused parameter. **DatabendSinkAggregatedCommitter.java:62** - The new `volatile boolean aborted` field lacks JavaDoc explaining its purpose and concurrent semantics. **DatabendCDCSink.java:70-96** - The abort scenario is not tested. The E2E test only covers normal completion without validating the "checkpoint abort → abort() → close()" flow where the `aborted` flag prevents final merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
