DanielCarter-stack commented on PR #10372: URL: https://github.com/apache/seatunnel/pull/10372#issuecomment-3772742068
<!-- code-pr-reviewer --> Thanks! - **MAJOR** `seatunnel-connectors-v2/connector-cdc/connector-cdc-base/src/main/java/org/apache/seatunnel/connectors/cdc/base/option/JdbcSourceOptions.java:29-159` (JdbcSourceOptions): **MAJOR**: `JdbcSourceOptions` lacks `getBaseRule()` method in `connector-cdc-base/src/main/java/org/apache/seatunnel/connectors/cdc/base/option/JdbcSourceOptions.java:29-159`. When factories call `JdbcSourceOptions.getBaseRule()`, it invokes the parent class `SourceOptions.getBaseRule()` which only includes base CDC options (FORMAT, SNAPSHOT_SPLIT_SIZE, etc.) but not JDBC-specific options (HOSTNAME, PORT, USERNAME, PASSWORD, etc.). Although factories manually supplement these options in `optionRule()`, this inconsistency increases maintenance cost and risks incomplete configuration validation. Suggestion: Add `getBaseRule()` method in `JdbcSourceOptions` to include all JDBC common options. - **MINOR** `seatunnel-connectors-v2/connector-cdc/connector-cdc-mongodb/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/mongodb/config/MongodbIncrementalSourceOptions.java:122-133` (MongodbIncrementalSourceOptions#DEBEZIUM_PROPERTIES): **MINOR**: `MongodbIncrementalSourceOptions` redefines `DEBEZIUM_PROPERTIES` option in `connector-cdc-mongodb/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/mongodb/config/MongodbIncrementalSourceOptions.java:122-133`, which is already defined in parent class `SourceOptions`. This violates DRY principle and creates inconsistent Debezium configuration behavior. Suggestion: Remove the duplicate definition and set default values in `MongodbIncrementalSourceFactory.createSource()` method, or document why MongoDB needs different defaults. - **MINOR** `seatunnel-connectors-v2/connector-cdc/connector-cdc-base/src/main/java/org/apache/seatunnel/connectors/cdc/base/option/SourceOptions.java:33-38` (SourceOptions#URL): **MINOR**: URL option description is too simple in `connector-cdc-base/src/main/java/org/apache/seatunnel/connectors/cdc/base/option/SourceOptions.java:33-38` (only says "url"). It lacks format specification, relationship with hostname/port, usage examples, and deprecation notice for fallback key "base-url". Suggestion: Enhance description with format, examples (jdbc:mysql://localhost:3306), and deprecation notice for base-url. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
