LiJie20190102 commented on code in PR #10378:
URL: https://github.com/apache/seatunnel/pull/10378#discussion_r2716668842
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/test/java/org/apache/seatunnel/connectors/seatunnel/file/writer/OrcWriteStrategyTest.java:
##########
@@ -29,6 +29,7 @@
import
org.apache.seatunnel.connectors.seatunnel.file.sink.config.FileSinkConfig;
import
org.apache.seatunnel.connectors.seatunnel.file.sink.writer.OrcWriteStrategy;
import
org.apache.seatunnel.connectors.seatunnel.file.source.reader.OrcReadStrategy;
+import
org.apache.seatunnel.connectors.seatunnel.file.source.reader.OrcReadStrategyTest;
Review Comment:
ditto, you can extract `LocalConf`
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/test/java/org/apache/seatunnel/connectors/seatunnel/file/writer/FileSinkConfigTest.java:
##########
@@ -24,6 +24,7 @@
import org.apache.seatunnel.api.table.type.SeaTunnelDataType;
import org.apache.seatunnel.api.table.type.SeaTunnelRowType;
import
org.apache.seatunnel.connectors.seatunnel.file.sink.config.FileSinkConfig;
+import
org.apache.seatunnel.connectors.seatunnel.file.source.reader.OrcReadStrategyTest;
Review Comment:
Thank you for your contribution. I believe `OrcReadStrategyTest` should not
appear here. Please investigate and resolve the issue
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/source/reader/ParquetReadStrategy.java:
##########
@@ -140,7 +138,8 @@ public void read(FileSourceSplit split,
Collector<SeaTunnelRow> output)
fields = new Object[fieldsCount];
}
for (int i = 0; i < fieldsCount; i++) {
- Object data = record.get(indexes[i]);
Review Comment:
What is the reason for the modification here ?
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/test/java/org/apache/seatunnel/connectors/seatunnel/file/writer/CsvWriteStrategyTest.java:
##########
@@ -29,6 +29,7 @@
import
org.apache.seatunnel.connectors.seatunnel.file.sink.config.FileSinkConfig;
import
org.apache.seatunnel.connectors.seatunnel.file.sink.writer.CsvWriteStrategy;
import
org.apache.seatunnel.connectors.seatunnel.file.source.reader.CsvReadStrategy;
+import
org.apache.seatunnel.connectors.seatunnel.file.source.reader.ParquetReadStrategyTest;
Review Comment:
ditto
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/test/java/org/apache/seatunnel/connectors/seatunnel/file/writer/ParquetWriteStrategyTest.java:
##########
@@ -31,6 +31,7 @@
import
org.apache.seatunnel.connectors.seatunnel.file.sink.config.FileSinkConfig;
import
org.apache.seatunnel.connectors.seatunnel.file.sink.writer.ParquetWriteStrategy;
import
org.apache.seatunnel.connectors.seatunnel.file.source.reader.ParquetReadStrategy;
+import
org.apache.seatunnel.connectors.seatunnel.file.source.reader.ParquetReadStrategyTest;
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
