yht0827 commented on PR #10390: URL: https://github.com/apache/seatunnel/pull/10390#issuecomment-3797659605
@dybyte @DanielCarter-stack Thanks for the detailed reviews!
I've added the following test cases to cover the requested scenarios:
### JsonPathTransformTest
| Test Method | Purpose |
|-------------|---------|
| `testMultipleDateColumnsWithDifferentFormats` | Multiple date/timestamp
columns with different formats |
| `testMultipleDateColumnsWithNullValues` | Null values don't cause
conversion errors |
| `testSingleDateColumn` | Regression test - single date column still
works |
| `testMultipleDateColumnsWithSameFormat` | Same format columns can share
cache |
| `testMixedTypeColumns` | Mixed types (date + string + int) work
correctly |
| `testInvalidDateFormat` | Invalid date format throws exception |
| `testEmptyStringDateValue` | Empty string throws exception |
| `testLeapYearDate` | Leap year (2024-02-29) parses correctly |
### JsonRowDataSerDeSchemaTest
| Test Method | Purpose |
|-------------|---------|
| `testConvertToLocalDateWithEmptyString` | Empty string handling for
LocalDate conversion |
| `testConvertToLocalDateTimeWithEmptyString` | Empty string handling for
LocalDateTime conversion |
---
@DanielCarter-stack I'm also interested in working on issue 4. Will create
a follow-up PR after this one is merged.
Please review when you have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
