krutoileshii opened a new pull request, #10401:
URL: https://github.com/apache/seatunnel/pull/10401

   The current Iceberg connector simply passes iceberg.catalog.config through 
to Iceberg via CatalogUtil.buildIcebergCatalog (see IcebergCatalogLoader.java). 
The docs only show client.region and do not cover static AK/SK or 
client.credentials-provider. There is no existing wrapper that constructs a 
static AwsCredentialsProvider from configuration properties (contrast with 
S3File connector, which exposes access_key/secret_key as first-class options).
   
   A PR adding a provider like StaticAwsCredentialsProvider (implementing 
AwsCredentialsProvider with a static create(Map<String,String>) factory) under 
connector-iceberg would be a good addition, along with a docs example:
   ```hocon
   iceberg.catalog.config = {
     warehouse     = "s3://your-bucket/warehouse/"
     catalog-impl  = "org.apache.iceberg.aws.glue.GlueCatalog"
     io-impl       = "org.apache.iceberg.aws.s3.S3FileIO"
     client.region = "your-region"
     client.credentials-provider = 
"org.apache.seatunnel.connectors.seatunnel.iceberg.aws.StaticAwsCredentialsProvider"
     client.credentials-provider.access-key-id = "YOUR_ACCESS_KEY"
     client.credentials-provider.secret-access-key = "YOUR_SECRET_ACCESS_KEY"
   }
   ```
   
   ### Purpose of this pull request
   
   Provides wrapper around AWS authentication for StaticCredentialProvider to 
allow the use of static credentials with glue catlogs.
   
   Closes #10392
   
   ### Does this PR introduce _any_ user-facing change?
   
   - [x] Yes - Documentation Updated
   
   ### How was this patch tested?
   
   <!--
   
   1. Tested base implementation in my environment.
   2. Added tests to connector. 
   
   -->
   
   
   ### Check list
   
   * [ ] If any new Jar binary package adding in your PR, please add License 
Notice according
     [New License 
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [x] If necessary, please update the documentation to describe the new 
feature. https://github.com/apache/seatunnel/tree/dev/docs
   * [ ] If necessary, please update `incompatible-changes.md` to describe the 
incompatibility caused by this PR.
   * [ ] If you are contributing the connector code, please check that the 
following files are updated:
     1. Update 
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
 and add new connector information in it
     2. Update the pom file of 
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
     3. Add ci label in 
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
     4. Add e2e testcase in 
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
     5. Update connector 
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to