dybyte commented on PR #10399: URL: https://github.com/apache/seatunnel/pull/10399#issuecomment-3803686424
@DanielCarter-stack Issues 1, 7, 8, and 9 have been addressed. The `write` and `compaction` operations run on separate single threads, and the only shared resources are `fileNames` and `totalBytes`. Both of these resources are thread-safe, so we do not expect any concurrency issues. To be extra cautious, `synchronized` has been added to `recoverFromCrash()` and `write()`. Regarding the current compaction logic, tombstone records are not deleted because previous versions of the same keys may exist in other files. Even if duplicates occur, the compaction process keeps only the latest value in the merged file, effectively eliminating duplicates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
