hawk9821 commented on code in PR #10402: URL: https://github.com/apache/seatunnel/pull/10402#discussion_r2739434456
########## seatunnel-api/src/main/java/org/apache/seatunnel/api/metalake/gravitino/GravitinoTableSchemaConvertor.java: ########## @@ -0,0 +1,345 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.seatunnel.api.metalake.gravitino; + +import org.apache.seatunnel.shade.com.fasterxml.jackson.databind.JsonNode; + +import org.apache.seatunnel.api.metalake.MetaLakeTableSchemaConvertor; +import org.apache.seatunnel.api.table.catalog.CatalogTable; +import org.apache.seatunnel.api.table.catalog.Column; +import org.apache.seatunnel.api.table.catalog.ConstraintKey; +import org.apache.seatunnel.api.table.catalog.PhysicalColumn; +import org.apache.seatunnel.api.table.catalog.PrimaryKey; +import org.apache.seatunnel.api.table.catalog.TableIdentifier; +import org.apache.seatunnel.api.table.catalog.TablePath; +import org.apache.seatunnel.api.table.catalog.TableSchema; +import org.apache.seatunnel.api.table.type.ArrayType; +import org.apache.seatunnel.api.table.type.BasicType; +import org.apache.seatunnel.api.table.type.DecimalType; +import org.apache.seatunnel.api.table.type.LocalTimeType; +import org.apache.seatunnel.api.table.type.MapType; +import org.apache.seatunnel.api.table.type.PrimitiveByteArrayType; +import org.apache.seatunnel.api.table.type.SeaTunnelDataType; +import org.apache.seatunnel.common.constants.MetaLakeType; +import org.apache.seatunnel.common.exception.CommonError; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.regex.Matcher; +import java.util.regex.Pattern; + +/** + * Converter for transforming Gravitino table metadata into SeaTunnel CatalogTable format. + * + * <p>Reference documentation: + * + * <ul> + * <li><a + * href="https://gravitino.apache.org/docs/1.1.0/manage-relational-metadata-using-gravitino/#apache-gravitino-table-column-type";>Gravitino + * Column Types</a> + * <li><a + * href="https://gravitino.apache.org/docs/1.1.0/table-partitioning-distribution-sort-order-indexes#indexes";>Gravitino + * Indexes</a> + * </ul> + */ +public class GravitinoTableSchemaConvertor implements MetaLakeTableSchemaConvertor { + + private static final Pattern DECIMAL_PATTERN = + Pattern.compile( + "decimal\\s*\\(\\s*(\\d+)\\s*,\\s*(\\d+)\\s*\\)", Pattern.CASE_INSENSITIVE); + private static final Pattern VARCHAR_PATTERN = + Pattern.compile("varchar\\s*\\(\\s*(\\d+)\\s*\\)", Pattern.CASE_INSENSITIVE); + private static final Pattern CHAR_PATTERN = + Pattern.compile("char\\s*\\(\\s*(\\d+)\\s*\\)", Pattern.CASE_INSENSITIVE); + private static final Pattern FIXED_PATTERN = + Pattern.compile("fixed\\s*\\(\\s*(\\d+)\\s*\\)", Pattern.CASE_INSENSITIVE); + + private static final String JSON_FIELD_COLUMNS = "columns"; + private static final String JSON_FIELD_INDEXES = "indexes"; + private static final String JSON_FIELD_NAME = "name"; + private static final String JSON_FIELD_TYPE = "type"; + private static final String JSON_FIELD_NULLABLE = "nullable"; + private static final String JSON_FIELD_INDEX_TYPE = "indexType"; + private static final String JSON_FIELD_FIELD_NAMES = "fieldNames"; Review Comment: `JSON_FIELD_FIELD_NAMES` has semantic redundancy ########## seatunnel-api/src/main/java/org/apache/seatunnel/api/metalake/gravitino/GravitinoTableSchemaConvertor.java: ########## @@ -0,0 +1,345 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.seatunnel.api.metalake.gravitino; + +import org.apache.seatunnel.shade.com.fasterxml.jackson.databind.JsonNode; + +import org.apache.seatunnel.api.metalake.MetaLakeTableSchemaConvertor; +import org.apache.seatunnel.api.table.catalog.CatalogTable; +import org.apache.seatunnel.api.table.catalog.Column; +import org.apache.seatunnel.api.table.catalog.ConstraintKey; +import org.apache.seatunnel.api.table.catalog.PhysicalColumn; +import org.apache.seatunnel.api.table.catalog.PrimaryKey; +import org.apache.seatunnel.api.table.catalog.TableIdentifier; +import org.apache.seatunnel.api.table.catalog.TablePath; +import org.apache.seatunnel.api.table.catalog.TableSchema; +import org.apache.seatunnel.api.table.type.ArrayType; +import org.apache.seatunnel.api.table.type.BasicType; +import org.apache.seatunnel.api.table.type.DecimalType; +import org.apache.seatunnel.api.table.type.LocalTimeType; +import org.apache.seatunnel.api.table.type.MapType; +import org.apache.seatunnel.api.table.type.PrimitiveByteArrayType; +import org.apache.seatunnel.api.table.type.SeaTunnelDataType; +import org.apache.seatunnel.common.constants.MetaLakeType; +import org.apache.seatunnel.common.exception.CommonError; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.regex.Matcher; +import java.util.regex.Pattern; + +/** + * Converter for transforming Gravitino table metadata into SeaTunnel CatalogTable format. + * + * <p>Reference documentation: + * + * <ul> + * <li><a + * href="https://gravitino.apache.org/docs/1.1.0/manage-relational-metadata-using-gravitino/#apache-gravitino-table-column-type";>Gravitino + * Column Types</a> + * <li><a + * href="https://gravitino.apache.org/docs/1.1.0/table-partitioning-distribution-sort-order-indexes#indexes";>Gravitino + * Indexes</a> + * </ul> + */ +public class GravitinoTableSchemaConvertor implements MetaLakeTableSchemaConvertor { + + private static final Pattern DECIMAL_PATTERN = + Pattern.compile( + "decimal\\s*\\(\\s*(\\d+)\\s*,\\s*(\\d+)\\s*\\)", Pattern.CASE_INSENSITIVE); + private static final Pattern VARCHAR_PATTERN = + Pattern.compile("varchar\\s*\\(\\s*(\\d+)\\s*\\)", Pattern.CASE_INSENSITIVE); + private static final Pattern CHAR_PATTERN = + Pattern.compile("char\\s*\\(\\s*(\\d+)\\s*\\)", Pattern.CASE_INSENSITIVE); + private static final Pattern FIXED_PATTERN = + Pattern.compile("fixed\\s*\\(\\s*(\\d+)\\s*\\)", Pattern.CASE_INSENSITIVE); + + private static final String JSON_FIELD_COLUMNS = "columns"; + private static final String JSON_FIELD_INDEXES = "indexes"; + private static final String JSON_FIELD_NAME = "name"; + private static final String JSON_FIELD_TYPE = "type"; + private static final String JSON_FIELD_NULLABLE = "nullable"; + private static final String JSON_FIELD_INDEX_TYPE = "indexType"; + private static final String JSON_FIELD_FIELD_NAMES = "fieldNames"; + + // Complex type JSON fields + private static final String JSON_FIELD_ELEMENT_TYPE = "elementType"; + private static final String JSON_FIELD_KEY_TYPE = "keyType"; + private static final String JSON_FIELD_VALUE_TYPE = "valueType"; + + private static final String INDEX_TYPE_PRIMARY_KEY = "PRIMARY_KEY"; + private static final String INDEX_TYPE_UNIQUE_KEY = "UNIQUE_KEY"; + + @Override + public TableSchema convertor(JsonNode metaInfo) { + List<Column> columns = new ArrayList<>(); + PrimaryKey primaryKey = null; + List<ConstraintKey> constraintKeys = new ArrayList<>(); + // Parse columns + JsonNode columnsNode = metaInfo.get(JSON_FIELD_COLUMNS); + if (columnsNode != null && columnsNode.isArray()) { + for (JsonNode columnNode : columnsNode) { + columns.add(parseColumn(columnNode)); + } + } + // Parse indexes + JsonNode indexesNode = metaInfo.get(JSON_FIELD_INDEXES); + if (indexesNode != null && indexesNode.isArray()) { + for (JsonNode indexNode : indexesNode) { + String indexType = getTextValue(indexNode, JSON_FIELD_INDEX_TYPE); + if (INDEX_TYPE_PRIMARY_KEY.equalsIgnoreCase(indexType)) { + primaryKey = parsePrimaryKey(indexNode); + } else if (INDEX_TYPE_UNIQUE_KEY.equalsIgnoreCase(indexType)) { + constraintKeys.add(parseUniqueKey(indexNode)); + } + } + } + // Build table schema + TableSchema.Builder schemaBuilder = TableSchema.builder().columns(columns); + if (primaryKey != null) { + schemaBuilder.primaryKey(primaryKey); + } + if (!constraintKeys.isEmpty()) { + schemaBuilder.constraintKey(constraintKeys); + } + return schemaBuilder.build(); + } + + @Override + public CatalogTable buildCatalogTable( + String catalogName, TablePath tablePath, TableSchema tableSchema) { + TableIdentifier tableIdentifier = TableIdentifier.of(catalogName, tablePath); + // Build catalog table + return CatalogTable.of( + tableIdentifier, + tableSchema, + new HashMap<>(), + new ArrayList<>(), + null, + catalogName); + } + + /** Parse a column node from Gravitino JSON. */ + private Column parseColumn(JsonNode columnNode) { + String name = getTextValue(columnNode, JSON_FIELD_NAME); + boolean nullable = + columnNode.has(JSON_FIELD_NULLABLE) + && columnNode.get(JSON_FIELD_NULLABLE).asBoolean(); + JsonNode typeNode = columnNode.get(JSON_FIELD_TYPE); + if (typeNode == null) { + throw CommonError.convertToSeaTunnelTypeError( + MetaLakeType.GRAVITINO.getType(), "null", name); + } + SeaTunnelDataType<?> dataType = convertGravitinoType(name, typeNode); + String typeStrForLength = typeNode.isTextual() ? typeNode.asText() : null; + Long columnLength = typeStrForLength == null ? null : extractColumnLength(typeStrForLength); + Integer scale = typeStrForLength == null ? null : extractScale(typeStrForLength); + return PhysicalColumn.builder() + .name(name) + .dataType(dataType) + .columnLength(columnLength) + .scale(scale) + .nullable(nullable) + .build(); + } + + /** + * Convert Gravitino type to SeaTunnel DataType. + * + * <p>Handles both simple types (string) and complex types (JSON object): + * + * <ul> + * <li>Simple types: "integer", "varchar(100)", "decimal(10,2)", "map<string,int>", + * "array<int>" + * <li>Complex types: + * <ul> + * <li>list: {"type": "list", "containsNull": boolean, "elementType": type JSON} + * <li>map: {"type": "map", "keyType": type JSON, "valueType": type JSON, + * "valueContainsNull": boolean} + * </ul> + * </ul> + * + * @param fieldName the field name for error reporting + * @param typeNode the JSON node representing the type (string or object) + * @return the corresponding SeaTunnel data type + */ + private SeaTunnelDataType<?> convertGravitinoType(String fieldName, JsonNode typeNode) { + // Handle complex type (JSON object) + if (typeNode.isObject()) { + JsonNode typeField = typeNode.get(JSON_FIELD_TYPE); + if (typeField == null || !typeField.isTextual()) { + throw CommonError.convertToSeaTunnelTypeError( + MetaLakeType.GRAVITINO.getType(), typeNode.toString(), fieldName); + } + String type = typeField.asText().toLowerCase(); + switch (type) { + case "list": + JsonNode elementType = typeNode.get(JSON_FIELD_ELEMENT_TYPE); + if (elementType == null) { + throw CommonError.convertToSeaTunnelTypeError( + MetaLakeType.GRAVITINO.getType(), + "list without elementType", + fieldName); + } + return ArrayType.of(convertGravitinoType(fieldName, elementType)); + + case "map": + JsonNode keyType = typeNode.get(JSON_FIELD_KEY_TYPE); + JsonNode valueType = typeNode.get(JSON_FIELD_VALUE_TYPE); + if (keyType == null || valueType == null) { + throw CommonError.convertToSeaTunnelTypeError( + MetaLakeType.GRAVITINO.getType(), + "map without keyType or valueType", + fieldName); + } + return new MapType<>( + convertGravitinoType(fieldName, keyType), + convertGravitinoType(fieldName, valueType)); + case "struct": + case "union": + default: + throw CommonError.convertToSeaTunnelTypeError( + MetaLakeType.GRAVITINO.getType(), type, fieldName); + } + } + // Handle simple type (string) + if (!typeNode.isTextual()) { + throw CommonError.convertToSeaTunnelTypeError( + MetaLakeType.GRAVITINO.getType(), typeNode.toString(), fieldName); + } + String gravitinoType = typeNode.asText(); + String normalizedType = gravitinoType.trim().toLowerCase(); + // Handle decimal type: decimal(precision, scale) + Matcher decimalMatcher = DECIMAL_PATTERN.matcher(gravitinoType); Review Comment: The regular matching logic for DECIMAL_PATTERN is placed outside the switch statement. All simple types (including boolean, byte, string, and other types unrelated to decimal) will perform a regular matching operation before entering the type matching branch, resulting in a large amount of meaningless performance overhead. The higher the frequency of method calls, the more obvious the performance loss. ########## seatunnel-api/src/main/java/org/apache/seatunnel/api/metalake/gravitino/GravitinoTableSchemaConvertor.java: ########## @@ -0,0 +1,345 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.seatunnel.api.metalake.gravitino; + +import org.apache.seatunnel.shade.com.fasterxml.jackson.databind.JsonNode; + +import org.apache.seatunnel.api.metalake.MetaLakeTableSchemaConvertor; +import org.apache.seatunnel.api.table.catalog.CatalogTable; +import org.apache.seatunnel.api.table.catalog.Column; +import org.apache.seatunnel.api.table.catalog.ConstraintKey; +import org.apache.seatunnel.api.table.catalog.PhysicalColumn; +import org.apache.seatunnel.api.table.catalog.PrimaryKey; +import org.apache.seatunnel.api.table.catalog.TableIdentifier; +import org.apache.seatunnel.api.table.catalog.TablePath; +import org.apache.seatunnel.api.table.catalog.TableSchema; +import org.apache.seatunnel.api.table.type.ArrayType; +import org.apache.seatunnel.api.table.type.BasicType; +import org.apache.seatunnel.api.table.type.DecimalType; +import org.apache.seatunnel.api.table.type.LocalTimeType; +import org.apache.seatunnel.api.table.type.MapType; +import org.apache.seatunnel.api.table.type.PrimitiveByteArrayType; +import org.apache.seatunnel.api.table.type.SeaTunnelDataType; +import org.apache.seatunnel.common.constants.MetaLakeType; +import org.apache.seatunnel.common.exception.CommonError; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.regex.Matcher; +import java.util.regex.Pattern; + +/** + * Converter for transforming Gravitino table metadata into SeaTunnel CatalogTable format. + * + * <p>Reference documentation: + * + * <ul> + * <li><a + * href="https://gravitino.apache.org/docs/1.1.0/manage-relational-metadata-using-gravitino/#apache-gravitino-table-column-type";>Gravitino + * Column Types</a> + * <li><a + * href="https://gravitino.apache.org/docs/1.1.0/table-partitioning-distribution-sort-order-indexes#indexes";>Gravitino + * Indexes</a> + * </ul> + */ +public class GravitinoTableSchemaConvertor implements MetaLakeTableSchemaConvertor { + + private static final Pattern DECIMAL_PATTERN = + Pattern.compile( + "decimal\\s*\\(\\s*(\\d+)\\s*,\\s*(\\d+)\\s*\\)", Pattern.CASE_INSENSITIVE); + private static final Pattern VARCHAR_PATTERN = + Pattern.compile("varchar\\s*\\(\\s*(\\d+)\\s*\\)", Pattern.CASE_INSENSITIVE); + private static final Pattern CHAR_PATTERN = + Pattern.compile("char\\s*\\(\\s*(\\d+)\\s*\\)", Pattern.CASE_INSENSITIVE); + private static final Pattern FIXED_PATTERN = + Pattern.compile("fixed\\s*\\(\\s*(\\d+)\\s*\\)", Pattern.CASE_INSENSITIVE); + + private static final String JSON_FIELD_COLUMNS = "columns"; + private static final String JSON_FIELD_INDEXES = "indexes"; + private static final String JSON_FIELD_NAME = "name"; + private static final String JSON_FIELD_TYPE = "type"; + private static final String JSON_FIELD_NULLABLE = "nullable"; + private static final String JSON_FIELD_INDEX_TYPE = "indexType"; + private static final String JSON_FIELD_FIELD_NAMES = "fieldNames"; + + // Complex type JSON fields + private static final String JSON_FIELD_ELEMENT_TYPE = "elementType"; + private static final String JSON_FIELD_KEY_TYPE = "keyType"; + private static final String JSON_FIELD_VALUE_TYPE = "valueType"; + + private static final String INDEX_TYPE_PRIMARY_KEY = "PRIMARY_KEY"; + private static final String INDEX_TYPE_UNIQUE_KEY = "UNIQUE_KEY"; + + @Override + public TableSchema convertor(JsonNode metaInfo) { + List<Column> columns = new ArrayList<>(); + PrimaryKey primaryKey = null; + List<ConstraintKey> constraintKeys = new ArrayList<>(); + // Parse columns + JsonNode columnsNode = metaInfo.get(JSON_FIELD_COLUMNS); + if (columnsNode != null && columnsNode.isArray()) { + for (JsonNode columnNode : columnsNode) { + columns.add(parseColumn(columnNode)); + } + } + // Parse indexes + JsonNode indexesNode = metaInfo.get(JSON_FIELD_INDEXES); + if (indexesNode != null && indexesNode.isArray()) { + for (JsonNode indexNode : indexesNode) { + String indexType = getTextValue(indexNode, JSON_FIELD_INDEX_TYPE); + if (INDEX_TYPE_PRIMARY_KEY.equalsIgnoreCase(indexType)) { + primaryKey = parsePrimaryKey(indexNode); + } else if (INDEX_TYPE_UNIQUE_KEY.equalsIgnoreCase(indexType)) { + constraintKeys.add(parseUniqueKey(indexNode)); + } + } + } + // Build table schema + TableSchema.Builder schemaBuilder = TableSchema.builder().columns(columns); + if (primaryKey != null) { + schemaBuilder.primaryKey(primaryKey); + } + if (!constraintKeys.isEmpty()) { + schemaBuilder.constraintKey(constraintKeys); + } + return schemaBuilder.build(); + } + + @Override + public CatalogTable buildCatalogTable( + String catalogName, TablePath tablePath, TableSchema tableSchema) { + TableIdentifier tableIdentifier = TableIdentifier.of(catalogName, tablePath); + // Build catalog table + return CatalogTable.of( + tableIdentifier, + tableSchema, + new HashMap<>(), + new ArrayList<>(), + null, + catalogName); + } + + /** Parse a column node from Gravitino JSON. */ + private Column parseColumn(JsonNode columnNode) { + String name = getTextValue(columnNode, JSON_FIELD_NAME); + boolean nullable = + columnNode.has(JSON_FIELD_NULLABLE) + && columnNode.get(JSON_FIELD_NULLABLE).asBoolean(); + JsonNode typeNode = columnNode.get(JSON_FIELD_TYPE); + if (typeNode == null) { + throw CommonError.convertToSeaTunnelTypeError( + MetaLakeType.GRAVITINO.getType(), "null", name); + } + SeaTunnelDataType<?> dataType = convertGravitinoType(name, typeNode); + String typeStrForLength = typeNode.isTextual() ? typeNode.asText() : null; + Long columnLength = typeStrForLength == null ? null : extractColumnLength(typeStrForLength); + Integer scale = typeStrForLength == null ? null : extractScale(typeStrForLength); + return PhysicalColumn.builder() + .name(name) + .dataType(dataType) + .columnLength(columnLength) + .scale(scale) + .nullable(nullable) + .build(); + } + + /** + * Convert Gravitino type to SeaTunnel DataType. + * + * <p>Handles both simple types (string) and complex types (JSON object): + * + * <ul> + * <li>Simple types: "integer", "varchar(100)", "decimal(10,2)", "map<string,int>", + * "array<int>" + * <li>Complex types: + * <ul> + * <li>list: {"type": "list", "containsNull": boolean, "elementType": type JSON} + * <li>map: {"type": "map", "keyType": type JSON, "valueType": type JSON, + * "valueContainsNull": boolean} + * </ul> + * </ul> + * + * @param fieldName the field name for error reporting + * @param typeNode the JSON node representing the type (string or object) + * @return the corresponding SeaTunnel data type + */ + private SeaTunnelDataType<?> convertGravitinoType(String fieldName, JsonNode typeNode) { + // Handle complex type (JSON object) + if (typeNode.isObject()) { + JsonNode typeField = typeNode.get(JSON_FIELD_TYPE); + if (typeField == null || !typeField.isTextual()) { + throw CommonError.convertToSeaTunnelTypeError( + MetaLakeType.GRAVITINO.getType(), typeNode.toString(), fieldName); + } + String type = typeField.asText().toLowerCase(); + switch (type) { + case "list": + JsonNode elementType = typeNode.get(JSON_FIELD_ELEMENT_TYPE); + if (elementType == null) { + throw CommonError.convertToSeaTunnelTypeError( + MetaLakeType.GRAVITINO.getType(), + "list without elementType", + fieldName); + } + return ArrayType.of(convertGravitinoType(fieldName, elementType)); + + case "map": + JsonNode keyType = typeNode.get(JSON_FIELD_KEY_TYPE); + JsonNode valueType = typeNode.get(JSON_FIELD_VALUE_TYPE); + if (keyType == null || valueType == null) { + throw CommonError.convertToSeaTunnelTypeError( + MetaLakeType.GRAVITINO.getType(), + "map without keyType or valueType", + fieldName); + } + return new MapType<>( + convertGravitinoType(fieldName, keyType), + convertGravitinoType(fieldName, valueType)); + case "struct": + case "union": + default: + throw CommonError.convertToSeaTunnelTypeError( + MetaLakeType.GRAVITINO.getType(), type, fieldName); + } + } + // Handle simple type (string) + if (!typeNode.isTextual()) { + throw CommonError.convertToSeaTunnelTypeError( + MetaLakeType.GRAVITINO.getType(), typeNode.toString(), fieldName); + } + String gravitinoType = typeNode.asText(); + String normalizedType = gravitinoType.trim().toLowerCase(); + // Handle decimal type: decimal(precision, scale) + Matcher decimalMatcher = DECIMAL_PATTERN.matcher(gravitinoType); + if (decimalMatcher.find()) { + int precision = Integer.parseInt(decimalMatcher.group(1)); + int scale = Integer.parseInt(decimalMatcher.group(2)); + return new DecimalType(precision, scale); + } + // Remove parameters for simple type matching + String baseType = normalizedType.split("\\(")[0].trim(); + switch (baseType) { + case "boolean": + return BasicType.BOOLEAN_TYPE; + case "byte": + case "byte unsigned": + return BasicType.BYTE_TYPE; + case "short": + case "short unsigned": + return BasicType.SHORT_TYPE; + case "integer": + case "integer unsigned": Review Comment: byte unsigned, short unsigned, integer unsigned, and long unsigned are all matched through independent case branches. The mapping logic is completely consistent with that of their corresponding signed types, yet the branches are written repeatedly. When adding new unsigned types, additional cases need to be added, resulting in extremely low code scalability. We should preprocess the unsigned type to reduce switch branch logic. ``` if (normalizedType.endsWith ("unsigned")) { baseType = normalizedType.replace ("unsigned", "").trim (); } ``` ########## seatunnel-api/src/main/java/org/apache/seatunnel/api/metalake/gravitino/GravitinoTableSchemaConvertor.java: ########## @@ -0,0 +1,345 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.seatunnel.api.metalake.gravitino; + +import org.apache.seatunnel.shade.com.fasterxml.jackson.databind.JsonNode; + +import org.apache.seatunnel.api.metalake.MetaLakeTableSchemaConvertor; +import org.apache.seatunnel.api.table.catalog.CatalogTable; +import org.apache.seatunnel.api.table.catalog.Column; +import org.apache.seatunnel.api.table.catalog.ConstraintKey; +import org.apache.seatunnel.api.table.catalog.PhysicalColumn; +import org.apache.seatunnel.api.table.catalog.PrimaryKey; +import org.apache.seatunnel.api.table.catalog.TableIdentifier; +import org.apache.seatunnel.api.table.catalog.TablePath; +import org.apache.seatunnel.api.table.catalog.TableSchema; +import org.apache.seatunnel.api.table.type.ArrayType; +import org.apache.seatunnel.api.table.type.BasicType; +import org.apache.seatunnel.api.table.type.DecimalType; +import org.apache.seatunnel.api.table.type.LocalTimeType; +import org.apache.seatunnel.api.table.type.MapType; +import org.apache.seatunnel.api.table.type.PrimitiveByteArrayType; +import org.apache.seatunnel.api.table.type.SeaTunnelDataType; +import org.apache.seatunnel.common.constants.MetaLakeType; +import org.apache.seatunnel.common.exception.CommonError; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.regex.Matcher; +import java.util.regex.Pattern; + +/** + * Converter for transforming Gravitino table metadata into SeaTunnel CatalogTable format. + * + * <p>Reference documentation: + * + * <ul> + * <li><a + * href="https://gravitino.apache.org/docs/1.1.0/manage-relational-metadata-using-gravitino/#apache-gravitino-table-column-type";>Gravitino + * Column Types</a> + * <li><a + * href="https://gravitino.apache.org/docs/1.1.0/table-partitioning-distribution-sort-order-indexes#indexes";>Gravitino + * Indexes</a> + * </ul> + */ +public class GravitinoTableSchemaConvertor implements MetaLakeTableSchemaConvertor { + + private static final Pattern DECIMAL_PATTERN = + Pattern.compile( + "decimal\\s*\\(\\s*(\\d+)\\s*,\\s*(\\d+)\\s*\\)", Pattern.CASE_INSENSITIVE); + private static final Pattern VARCHAR_PATTERN = + Pattern.compile("varchar\\s*\\(\\s*(\\d+)\\s*\\)", Pattern.CASE_INSENSITIVE); + private static final Pattern CHAR_PATTERN = + Pattern.compile("char\\s*\\(\\s*(\\d+)\\s*\\)", Pattern.CASE_INSENSITIVE); + private static final Pattern FIXED_PATTERN = + Pattern.compile("fixed\\s*\\(\\s*(\\d+)\\s*\\)", Pattern.CASE_INSENSITIVE); + + private static final String JSON_FIELD_COLUMNS = "columns"; + private static final String JSON_FIELD_INDEXES = "indexes"; + private static final String JSON_FIELD_NAME = "name"; + private static final String JSON_FIELD_TYPE = "type"; + private static final String JSON_FIELD_NULLABLE = "nullable"; + private static final String JSON_FIELD_INDEX_TYPE = "indexType"; + private static final String JSON_FIELD_FIELD_NAMES = "fieldNames"; + + // Complex type JSON fields + private static final String JSON_FIELD_ELEMENT_TYPE = "elementType"; + private static final String JSON_FIELD_KEY_TYPE = "keyType"; + private static final String JSON_FIELD_VALUE_TYPE = "valueType"; + + private static final String INDEX_TYPE_PRIMARY_KEY = "PRIMARY_KEY"; + private static final String INDEX_TYPE_UNIQUE_KEY = "UNIQUE_KEY"; + + @Override + public TableSchema convertor(JsonNode metaInfo) { + List<Column> columns = new ArrayList<>(); + PrimaryKey primaryKey = null; + List<ConstraintKey> constraintKeys = new ArrayList<>(); + // Parse columns + JsonNode columnsNode = metaInfo.get(JSON_FIELD_COLUMNS); + if (columnsNode != null && columnsNode.isArray()) { + for (JsonNode columnNode : columnsNode) { + columns.add(parseColumn(columnNode)); + } + } + // Parse indexes + JsonNode indexesNode = metaInfo.get(JSON_FIELD_INDEXES); + if (indexesNode != null && indexesNode.isArray()) { + for (JsonNode indexNode : indexesNode) { + String indexType = getTextValue(indexNode, JSON_FIELD_INDEX_TYPE); + if (INDEX_TYPE_PRIMARY_KEY.equalsIgnoreCase(indexType)) { + primaryKey = parsePrimaryKey(indexNode); + } else if (INDEX_TYPE_UNIQUE_KEY.equalsIgnoreCase(indexType)) { + constraintKeys.add(parseUniqueKey(indexNode)); + } + } + } + // Build table schema + TableSchema.Builder schemaBuilder = TableSchema.builder().columns(columns); + if (primaryKey != null) { + schemaBuilder.primaryKey(primaryKey); + } + if (!constraintKeys.isEmpty()) { + schemaBuilder.constraintKey(constraintKeys); + } + return schemaBuilder.build(); + } + + @Override + public CatalogTable buildCatalogTable( + String catalogName, TablePath tablePath, TableSchema tableSchema) { + TableIdentifier tableIdentifier = TableIdentifier.of(catalogName, tablePath); + // Build catalog table + return CatalogTable.of( + tableIdentifier, + tableSchema, + new HashMap<>(), + new ArrayList<>(), + null, + catalogName); + } + + /** Parse a column node from Gravitino JSON. */ + private Column parseColumn(JsonNode columnNode) { + String name = getTextValue(columnNode, JSON_FIELD_NAME); + boolean nullable = + columnNode.has(JSON_FIELD_NULLABLE) + && columnNode.get(JSON_FIELD_NULLABLE).asBoolean(); + JsonNode typeNode = columnNode.get(JSON_FIELD_TYPE); + if (typeNode == null) { + throw CommonError.convertToSeaTunnelTypeError( + MetaLakeType.GRAVITINO.getType(), "null", name); + } + SeaTunnelDataType<?> dataType = convertGravitinoType(name, typeNode); + String typeStrForLength = typeNode.isTextual() ? typeNode.asText() : null; + Long columnLength = typeStrForLength == null ? null : extractColumnLength(typeStrForLength); + Integer scale = typeStrForLength == null ? null : extractScale(typeStrForLength); + return PhysicalColumn.builder() + .name(name) + .dataType(dataType) + .columnLength(columnLength) + .scale(scale) + .nullable(nullable) + .build(); + } + + /** + * Convert Gravitino type to SeaTunnel DataType. + * + * <p>Handles both simple types (string) and complex types (JSON object): + * + * <ul> + * <li>Simple types: "integer", "varchar(100)", "decimal(10,2)", "map<string,int>", + * "array<int>" + * <li>Complex types: + * <ul> + * <li>list: {"type": "list", "containsNull": boolean, "elementType": type JSON} + * <li>map: {"type": "map", "keyType": type JSON, "valueType": type JSON, + * "valueContainsNull": boolean} + * </ul> + * </ul> + * + * @param fieldName the field name for error reporting + * @param typeNode the JSON node representing the type (string or object) + * @return the corresponding SeaTunnel data type + */ + private SeaTunnelDataType<?> convertGravitinoType(String fieldName, JsonNode typeNode) { + // Handle complex type (JSON object) + if (typeNode.isObject()) { Review Comment: The code first handles complex types (Object) through an if statement. After processing, it does not break out and continues to execute the subsequent if judgment for simple types (!typeNode.isTextual()). Even if it is determined to be a complex type and processing is completed, it still performs irrelevant condition checks, resulting in invalid branch judgments and insufficient logical rigor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
