corgy-w commented on code in PR #10431:
URL: https://github.com/apache/seatunnel/pull/10431#discussion_r2754850980
##########
seatunnel-engine/seatunnel-engine-core/src/main/java/org/apache/seatunnel/engine/core/classloader/DefaultClassLoaderService.java:
##########
@@ -91,8 +97,8 @@ public synchronized ClassLoader getClassLoader(long jobId,
Collection<URL> jars)
} else {
log.debug("Run the test class without file checking");
}
- ClassLoader classLoader = new SeaTunnelChildFirstClassLoader(jars);
- log.info("Create classloader for job {} with jars {}", jobId,
jars);
+ ClassLoader classLoader = new
SeaTunnelChildFirstClassLoader(resolvedJars);
+ log.info("Create classloader for job {} with resolvedJars {}",
jobId, resolvedJars);
Review Comment:
`resolvedJars` this name can be written back to the jars, I feel it is not
necessary to call `resolvedJars` `PathResolver. ResolvePathEnv (resolvedJars);`
It can be used as a decorator, right? Why make a copy? Is it still useful here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
