DanielCarter-stack commented on issue #10440: URL: https://github.com/apache/seatunnel/issues/10440#issuecomment-3839984156
<!-- code-pr-reviewer --> Thanks for reporting this bug. The analysis confirms that `DATETIMEOFFSET` is incorrectly mapped to `LOCAL_DATE_TIME_TYPE` and should be `OFFSET_DATE_TIME_TYPE` to preserve timezone information. Key findings: - `SqlServerTypeConverter.java:295` currently maps `DATETIMEOFFSET` to `LOCAL_DATE_TIME_TYPE` (SqlType.TIMESTAMP) - `PostgresTypeConverter.java:278` correctly maps `timestamptz` to `OFFSET_DATE_TIME_TYPE` as a reference - `SqlServerTypeConverterTest.java:543` also needs the corresponding assertion update - `LocalTimeType.OFFSET_DATE_TIME_TYPE` (SqlType.TIMESTAMP_TZ) is available in the API Suggested fix scope: 1. Change `SqlServerTypeConverter.java:295` to use `OFFSET_DATE_TIME_TYPE` 2. Update the test assertion in `SqlServerTypeConverterTest.java:543` 3. Verify `reconvert()` method handles `TIMESTAMP_TZ` / `OffsetDateTime` correctly A PR to fix this would be welcome. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
