yzeng1618 commented on code in PR #10047:
URL: https://github.com/apache/seatunnel/pull/10047#discussion_r2758272624
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/converter/BasicDataConverter.java:
##########
@@ -443,38 +443,9 @@ default OffsetDateTime convertOffsetDateTime(T typeDefine,
Object value)
if (value instanceof OffsetDateTime) {
return (OffsetDateTime) value;
}
- if (value instanceof LocalDateTime) {
Review Comment:
this touches the core BasicDataConverter, not only Oracle. The semantics of
TIMESTAMP_TZ require an offset, and inference via systemDefault will cause
cross-node inconsistency; therefore, we converge the default conversion of the
API, with the Oracle/JDBC layer responsible for producing OffsetDateTime. This
change only affects TIMESTAMP_TZ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
