davidzollo commented on PR #10411: URL: https://github.com/apache/seatunnel/pull/10411#issuecomment-3841221889
**Suggested addition** ```markdown ## Adding a New Connector When contributing a new connector, you MUST update: 1. `plugin-mapping.properties` - Add connector mapping 2. `seatunnel-dist/pom.xml` - Include in distribution 3. `seatunnel-e2e/` - Add E2E test cases 4. `config/plugin_config` - Add plugin configuration 5. `docs/en/connector-v2/` - Add English documentation 6. `docs/zh/connector-v2/` - Add Chinese documentation ``` **Suggested new section:** ```markdown ## Common Pitfalls to Avoid 1. **Don't use wildcard imports** - Spotless will fail 2. **Don't forget license headers** - All new files need ASF headers 3. **Don't skip `-nsu` flag** - Ensures build reproducibility 4. **Don't modify existing Option names** - Breaking change for users 5. **Don't commit without running spotless:apply** - CI will fail 6. **Don't use `System.out.println`** - Use proper logging framework ``` ## What Works Well 1. **Clear structure** - Well-organized sections 2. **Good examples** - Commit message format examples are helpful 3. **Backward compatibility emphasis** - Critical for production systems 4. **Repository structure** - Accurate and helpful 5. **License header template** - Essential for Apache projects -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
