DanielCarter-stack commented on issue #10442: URL: https://github.com/apache/seatunnel/issues/10442#issuecomment-3841882179
<!-- code-pr-reviewer --> Thank you for the detailed analysis and for offering to submit a PR! I've verified the issue. **Problem confirmed:** When `triggerCheckpoint()` throws an exception (e.g., Hazelcast `OperationTimeoutException` at `CheckpointCoordinator.java:684`), the exception is caught and logged at lines 687-689, but the code returns without decrementing `pendingCounter` (which was incremented at line 722). This causes `pendingCounter` to remain at 1, permanently blocking all subsequent checkpoint triggers at lines 564-568. **Affected files:** - `seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/checkpoint/CheckpointCoordinator.java` (lines 683-690, 722, 564-568) **Suggested fix:** Ensure `pendingCounter.decrementAndGet()` is called in the exception handling path at line 688, or use try-finally to guarantee proper counter management. Adding a unit test for exception scenarios would also be valuable. Looking forward to your PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
