DanielCarter-stack commented on issue #10444: URL: https://github.com/apache/seatunnel/issues/10444#issuecomment-3842872622
<!-- code-pr-reviewer --> Thanks for your contribution proposal! This is a valuable testing infrastructure improvement for the Kingbase connector. **Current status verified:** - Kingbase dialect implementation exists at `seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/kingbase/` - Current tests are in E2E module: `seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-3/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/JdbcKingbaseIT.java` - CI skips Kingbase tests due to local environment dependency **Suggested approach:** 1. Add Docker-based unit tests in `connector-jdbc/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/` using Testcontainers (similar to PostgreSQL/MySQL patterns) 2. Cover `JdbcCatalog` and `JdbcDialect` for Kingbase with edge cases 3. Verify CI passes, then migrate `JdbcKingbaseIT` logic to unit tests **Key dependency:** Confirm availability of a public Kingbase Docker image (e.g., `kingbaseadb/kdb` or equivalent) before implementation. Feel free to open a draft PR for early feedback on the Docker configuration and test structure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
