nielifeng commented on PR #10441:
URL: https://github.com/apache/seatunnel/pull/10441#issuecomment-3844687769
Thanks for the fix! The type mapping change to `OFFSET_DATE_TIME_TYPE` looks
correct for preserving timezone information.
However, I noticed a potential compatibility issue with the CDC connector,
which shares this type converter.
1. **CDC Converter Support**:
The `SeaTunnelRowDebeziumDeserializationConverters` class currently
lacks support for `SqlType.TIMESTAMP_TZ` (which corresponds to
`OFFSET_DATE_TIME_TYPE`).
Please verify if this change will cause `UnsupportedOperationException`
in CDC tasks. You likely need to add a case for `TIMESTAMP_TZ` in
`SeaTunnelRowDebeziumDeserializationConverters#createConverter`.
2. **TemporalConversions**:
If you update the Debezium converter, you might also need to add a
`toOffsetDateTime` utility method in `TemporalConversions.java` to handle the
conversion from Debezium's internal representation to `OffsetDateTime`.
It would be great if you could ensure that both JDBC and CDC connectors work
correctly with this new type mapping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
