DanielCarter-stack commented on PR #10447:
URL: https://github.com/apache/seatunnel/pull/10447#issuecomment-3847446156
<!-- code-pr-reviewer -->
<!-- cpr:pr_reply_v2_parts {"group": "apache/seatunnel#10447", "part": 1,
"total": 1} -->
### Issue 1: Configuration conversion has type incompatibility risk
**Location**: `HubSpotSource.java:46`
**Severity**: BLOCKER
**Recommendation**: Refactor to use custom Parameter class pattern
### Issue 2: Document naming does not follow project conventions
**Location**: `docs/en/connectors/source/HubSpot.md`
**Severity**: MINOR
**Recommendation**: Rename to `Hubspot.md` or standardize to capitalize only
the first letter
### Issue 3: Missing required configuration file updates
**Location**: `plugin-mapping.properties`, `seatunnel-dist/pom.xml`,
`config/plugin_config`
**Severity**: BLOCKER
**Recommendation**: Add all required configuration entries
### Issue 4: Custom Parameter class not implemented
**Location**: `HubSpotSource.java` overall design
**Severity**: MAJOR
**Recommendation**: Create `HubSpotSourceParameter` class
### Issue 6: Sensitive information may leak to logs
**Location**: `HubSpotSource.java:59`
**Severity**: MINOR
**Explanation**: This is a common issue with base classes; recommend
overriding toString() in HttpParameter
### Issue 7: Missing newline at end of file
**Location**: `docs/en/connectors/source/HubSpot.md:56`
**Severity**: MINOR
**Recommendation**: Add newline at end of file
### Issue 8: Inconsistent changelog format
**Location**: `docs/en/connectors/changelog/connector-http-hubspot.md`
**Severity**: MINOR
**Recommendation**: Use the same format as other HTTP connectors
### Issue 9: Completely lacking test coverage
**Location**: Entire `connector-http-hubspot` module
**Severity**: MAJOR
**Recommendation**: Add Factory tests and configuration conversion tests
### Issue 10: Documentation missing critical usage instructions
**Location**: `docs/en/connectors/source/HubSpot.md`
**Severity**: MINOR
**Recommendation**: Add documentation for pagination, rate limiting, etc.
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
