davidzollo commented on code in PR #10418:
URL: https://github.com/apache/seatunnel/pull/10418#discussion_r2764646394
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/master/JobMaster.java:
##########
@@ -890,6 +891,66 @@ public void savePipelineMetricsToHistory(PipelineLocation
pipelineLocation) {
this.cleanTaskGroupContext(pipelineLocation);
}
+ public void enqueuePipelineCleanupIfNeeded(
+ PipelineLocation pipelineLocation, PipelineStatus pipelineStatus) {
+ if (pipelineLocation == null || pipelineStatus == null) {
+ return;
+ }
+ boolean savepointEnd =
+ PipelineStatus.FINISHED.equals(pipelineStatus)
+ && checkpointManager != null
+ &&
checkpointManager.isPipelineSavePointEnd(pipelineLocation);
+ boolean shouldCleanup =
+ PipelineStatus.CANCELED.equals(pipelineStatus)
Review Comment:
Should we add cleanup for failed pipelines here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
