DanielCarter-stack commented on issue #10463: URL: https://github.com/apache/seatunnel/issues/10463#issuecomment-3864491332
<!-- code-pr-reviewer --> Thanks for the proposal! This feature doesn't exist in the `dev` branch. **Current state:** - Metrics in `MetricNames.java` focus on throughput (QPS, bytes) and cumulative counts - `BaseService.getJobMetrics()` returns basic aggregated metrics without task busyness ratios or wait time breakdowns - `IntermediateDisruptor` (buffer size: 1024) doesn't expose occupancy rate or wait time metrics - Web UI docs lack the busyness visualization panels **Implementation suggestions:** 1. Add new metric constants in `MetricNames.java` (e.g., `SOURCE_BUSY_RATIO`, `SINK_WAIT_TIME_NS`, `BUFFER_OCCUPANCY_RATIO`) 2. Track execution time breakdowns in `ConnectorMetricsCalcContext` using `System.nanoTime()` 3. Expose buffer occupancy statistics in `IntermediateQueue` implementations 4. Extend `BaseService.getJobMetrics()` to include new metric types while maintaining backward compatibility **Questions:** 1. How should the time window for busyness calculation be configured (rolling 1s/5s vs. since job start)? 2. Should these time-based metrics be configurable due to potential performance overhead? 3. Will the API response format be backward-compatible with existing clients? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
