DanielCarter-stack commented on issue #10471: URL: https://github.com/apache/seatunnel/issues/10471#issuecomment-3870122155
<!-- code-pr-reviewer --> Thanks for reporting this issue. I can confirm it's a valid bug. The `SapHanaTypeConverter` class lacks support for the `CHAR` data type. While SAP HANA supports `CHAR` and other dialects (MySQL, Oracle, PostgreSQL) handle it, the HANA converter's switch statement has no `CHAR` case, causing it to throw `CONVERT_TO_SEATUNNEL_TYPE_ERROR_SIMPLE` when encountering `CHAR` columns. **To fix this**, you would need to: 1. Add `public static final String HANA_CHAR = "CHAR";` to `SapHanaTypeConverter` (line ~45) 2. Add a `case HANA_CHAR:` branch mapping to `BasicType.STRING_TYPE` in the `convert()` method (line ~184) 3. Add a test case in `SapHanaTypeConverterTest` Relevant files: - `seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/saphana/SapHanaTypeConverter.java` - `seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/mysql/MySqlTypeConverter.java` (reference for CHAR handling) Would you like to submit a PR for this? If so, please also confirm your SeaTunnel version and whether the issue persists in the latest dev branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
