Copilot commented on code in PR #10495:
URL: https://github.com/apache/seatunnel/pull/10495#discussion_r2807164312
##########
pom.xml:
##########
@@ -695,6 +697,10 @@
<version>${maven-failsafe-plugin.version}</version>
<configuration>
<skip>${skipIT}</skip>
+ <!-- temporary fix for
https://github.com/testcontainers/testcontainers-java/issues/11491 -->
+ <systemPropertyVariables>
+ <api.version>1.44</api.version>
+ </systemPropertyVariables>
Review Comment:
According to the testcontainers GitHub issue #11491, the recommended
approach to fix this issue is to set the `DOCKER_API_VERSION` environment
variable rather than using a system property. Consider using
`<environmentVariables>` instead of (or in addition to)
`<systemPropertyVariables>`:
```xml
<environmentVariables>
<DOCKER_API_VERSION>1.44</DOCKER_API_VERSION>
</environmentVariables>
```
If the current approach with `api.version` system property doesn't work,
this alternative should resolve the Docker API version compatibility issue.
```suggestion
</systemPropertyVariables>
<environmentVariables>
<DOCKER_API_VERSION>1.44</DOCKER_API_VERSION>
</environmentVariables>
```
##########
pom.xml:
##########
@@ -666,6 +666,8 @@
<skip>${skipUT}</skip>
<systemPropertyVariables>
<jacoco-agent.destfile>${project.build.directory}/jacoco.exec</jacoco-agent.destfile>
+ <!-- temporary fix for
https://github.com/testcontainers/testcontainers-java/issues/11491 -->
+ <api.version>1.44</api.version>
</systemPropertyVariables>
Review Comment:
According to the testcontainers GitHub issue #11491, the recommended
approach to fix this issue is to set the `DOCKER_API_VERSION` environment
variable rather than using a system property. Consider using
`<environmentVariables>` instead of `<systemPropertyVariables>`:
```xml
<environmentVariables>
<DOCKER_API_VERSION>1.44</DOCKER_API_VERSION>
</environmentVariables>
```
If the current approach with `api.version` system property doesn't work,
this alternative should resolve the Docker API version compatibility issue.
```suggestion
</systemPropertyVariables>
<!-- temporary fix for
https://github.com/testcontainers/testcontainers-java/issues/11491 -->
<environmentVariables>
<DOCKER_API_VERSION>1.44</DOCKER_API_VERSION>
</environmentVariables>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
