Best2Two commented on PR #10497: URL: https://github.com/apache/seatunnel/pull/10497#issuecomment-3904899494
@davidzollo Thank you for the thorough review and catching those critical issues! 🙏 I've addressed all the concerns you raised: **1. Concurrency Bug (Critical)** ✅ - Fixed the lock inconsistency by ensuring `flush()` and `close()` both use the same `lock` object instead of `this` - This eliminates the risk of `ConcurrentModificationException` during checkpoints **2. Weak Retry Strategy** ✅ - Increased `maxRetries` from 3 to 10 - Implemented exponential backoff with jitter to prevent thundering herd issues - Total wait time now scales from ~200ms to 5 seconds (capped) across retries **Additional improvements:** - Renamed `flushTableAsync()` to `flushTable()` since it's actually synchronous The implementation now properly handles DynamoDB throttling scenarios and ready for another review. Please let me know if you spot anything else that needs attention! Thank you again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
