onceMisery opened a new pull request, #10499:
URL: https://github.com/apache/seatunnel/pull/10499
### Purpose of this pull request
This PR aims to improve the test coverage and stability of the DamengDB
connector.
Specifically, the following changes have been made:
1. **Added `DmdbDialectFactoryTest`**:
* Verified `dialectFactoryName` and `acceptsURL` logic.
* Tested `create` methods with different `FieldIdeEnum` configurations
(Original, Uppercase, Lowercase).
2. **Enhanced `DmdbDialect` Unit Tests**:
* Added tests for SQL generation: `getUpsertStatement`,
`getInsertIntoStatement`, `getDeleteStatement`, `getUpdateStatement`, and
`getRowExistsStatement`.
* Verified table identifier parsing and quoting logic
(`quoteIdentifier`, `tableIdentifier`).
* Tested `needsQuotesWithDefaultValue` for various data types (String
types vs Numeric types).
* Verified the correct instantiation of converters and mappers
(`TypeConverter`, `JdbcDialectTypeMapper`, `RowConverter`).
3. **Updated `pom.xml`**:
* Added necessary test dependencies: `testcontainers`, `junit-jupiter`
(for test container support).
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
* **Unit Tests**: Added comprehensive unit tests in `DmdbDialectFactoryTest`
and updated `DamengDialectContainerTest`.
* **Local Execution**: Ran all tests locally using Maven to ensure they pass
without errors.
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License
Notice according
[New License
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new
feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If necessary, please update `incompatible-changes.md` to describe the
incompatibility caused by this PR.
* [ ] If you are contributing the connector code, please check that the
following files are updated:
1. Update
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
and add new connector information in it
2. Update the pom file of
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
3. Add ci label in
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
4. Add e2e testcase in
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
5. Update connector
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
