MyeoungDev commented on PR #10505: URL: https://github.com/apache/seatunnel/pull/10505#issuecomment-3960424351
@DanielCarter-stack Thanks for your detailed review! I have updated the PR based on your feedback. Here are my responses to each point ### Issue 1. Regarding the seatunnel.sh script I did not make any changes to the `seatunnel.sh` script in this PR. Could you please double-check the diff? If I missed something or if there is a misunderstanding, please let me know, and I’ll look into it right away. ### Issue 2. Test case for recursive_file_scan Thank you for the great suggestion. I have added additional test cases to verify the `recursive_file_scan` option to ensure it works as expected. ### Issue 5. OssJindoFileSourceFactory Update I have updated the `OssJindoFileSourceFactory` as requested. ### Issue 6. Test Resource Cleanup Regarding the potential failure of test resource cleanup, I have updated the code to ensure that any cleanup issues are properly recorded in the logs. ### Issue3 Issue 7. Documentation issues I initially felt the descriptions for the options were sufficient, but if you feel the recursive_file_scan option needs more detailed explanation, I am happy to expand it. Additionally, please note that I am not familiar with Chinese. If updates to the Chinese documentation are required, please provide a guide or specific template, and I will follow it accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
