DanielCarter-stack commented on issue #10535:
URL: https://github.com/apache/seatunnel/issues/10535#issuecomment-3976457818
<!-- code-pr-reviewer -->
Thanks for creating this documentation issue! I've verified that:
1. The 4 methods in both interfaces indeed lack Javadoc:
- `SupportResourceShare.initMultiTableResourceManager(int, int)` (line 22)
-
`SupportResourceShare.setMultiTableResourceManager(MultiTableResourceManager<T>,
int)` (line 27)
- `MultiTableResourceManager.getSharedResource()` (line 25)
- `MultiTableResourceManager.close()` (line 29)
2. Your description of the calling sequence matches the actual
implementation in `MultiTableSinkWriter`:
- Initialization: lines 117-132 (constructors call `initResourceManager`)
- Cleanup: lines 350-352 (`close()` calls `resourceManager.close()`)
3. Parameter semantics are accurate:
- `tableSize` = number of target tables
- `queueSize` = parallel write queue count (thread pool size = `queueSize
* 2`)
- `queueIndex` = current writer's queue index (used for modulo-based
table assignment)
This is a valuable improvement for connector authors. Existing
implementations like `HudiMultiTableResourceManager` and
`JdbcMultiTableResourceManager` can serve as references when writing the
Javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
