DanielCarter-stack commented on issue #10538: URL: https://github.com/apache/seatunnel/issues/10538#issuecomment-3976460650
<!-- code-pr-reviewer --> Thanks for the documentation improvement request. I've verified the issue and confirmed that `MultiTableWriterRunnable` at `seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/multitablesink/MultiTableWriterRunnable.java` currently has no Javadoc on any of its four members (constructor, `run()`, `getThrowable()`, `getCurrentTableId()`). The concurrent control logic you described is accurate: `synchronized(this)` in the `run()` method (line 74-76) properly excludes concurrent execution with `snapshotState` in `MultiTableSinkWriter` (line 230), and the `row.getArity() == 0` check (lines 53-60) correctly filters schema evolution control signals. Contributors adding Javadoc should reference: - `MultiTableSinkWriter.java` (lines 89-106 for constructor usage, lines 134-142 for `subSinkErrorCheck()` calling `getThrowable()`) - `SeaTunnelRow.getTableId()` method for row-to-table mapping - Apply formatting with `./mvnw spotless:apply` and verify with `./mvnw -q -DskipTests verify` before submitting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
