DanielCarter-stack commented on issue #10540: URL: https://github.com/apache/seatunnel/issues/10540#issuecomment-3976462855
<!-- code-pr-reviewer --> Thanks for the documentation improvement request! I've verified that the `SeaTunnelTask.java` file exists at `seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/task/SeaTunnelTask.java` and the target methods indeed lack Javadoc comments. The state machine implementation (`WAITING_RESTORE → RUNNING → PREPARE_CLOSE → CLOSED`) is correctly defined in the `stateProcess()` method at line 137, and all other mentioned methods (`init()`, `close()`, `ack()`, `addState()`, `convertFlowToActionLifeCycle()`, `triggerSchemaChangeBeforeCheckpoint()`, `triggerSchemaChangeAfterCheckpoint()`) are present without documentation. For consistency, I recommend referring to the Javadoc style in `SeaTunnelTaskState.java` (for state definitions) or `CheckpointCoordinator.java` within the same module. This is a suitable "good first issue" for new contributors. Would you like to work on this? If so, please confirm and I'll assign it to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
