DanielCarter-stack commented on issue #10541: URL: https://github.com/apache/seatunnel/issues/10541#issuecomment-3976463845
<!-- code-pr-reviewer --> Thank you for proposing this documentation improvement. After reviewing the codebase, I can confirm that `SourceFlowLifeCycle` is missing method-level Javadoc. The target file exists at: - `seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/task/flow/SourceFlowLifeCycle.java` All methods listed in the issue match the current implementation (line numbers verified: init@115, open@129, collect@150, signalNoMoreElement@198, register@215, requestSplit@230, receivedSplits@259, triggerBarrier@267, notifyCheckpointComplete@330, notifyCheckpointAborted@335). For Javadoc style reference, please see: - `seatunnel-api/src/main/java/org/apache/seatunnel/api/source/SourceReader.java` This is a good help-wanted task. When contributing, please run `./mvnw spotless:apply` before committing. Pay special attention to documenting the schema-change checkpoint logic in `collect()` and the checkpoint lock mechanism in `triggerBarrier()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
