davidzollo commented on PR #10497: URL: https://github.com/apache/seatunnel/pull/10497#issuecomment-3981988209
I found a retry semantics issue in `DynamoDbSinkClient.flushWithRetry()`: - Current loop condition is `retryCount < maxRetries`, which means when `max_retries=0`, the first `batchWriteItem` is never executed. - Risk: users typically interpret `max_retries=0` as "no retry, but still do one initial write attempt". With current behavior, it fails immediately and can cause unexpected write failures. Suggestion: 1. Use attempt-based semantics: execute one initial write attempt first, then retry up to `max_retries` times (for example, `attempt <= maxRetries` where `attempt` starts from 0 or 1 consistently). 2. Add config validation to ensure `max_retries >= 0` in option parsing/config initialization. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
