nzw921rx commented on PR #10595:
URL: https://github.com/apache/seatunnel/pull/10595#issuecomment-4048982022
## What changes were proposed in this pull request?
1. **Unify decryption logic for all config formats** (fix Issue 4)
- Add explicit comment for JSON path decryption logic in
JobInfoService.java (lines 190-193) to clarify that decryption is handled in
RestUtil.buildConfig()
- Keep functional correctness while improving code maintainability (avoid
duplicate decryption)
2. **Enhance test coverage** (fix Issue 2)
- Add boundary condition tests: missing/empty shade.identifier, invalid
base64 strings, missing required fields
- Add file upload tests for SQL (.sql) and JSON (.json) formats (only
HOCON was tested before)
- Add error scenario tests: HOCON syntax errors, HTTP response code
verification for decryption exceptions
- Note: Concurrency/performance tests are marked as follow-up due to low
priority
3. **Security hardening for config logs** (optimize Issue 3)
- Add exception handling in ConfigShadeUtils.processConfig() to avoid
sensitive info (e.g., decrypted passwords) leakage in logs
- Log desensitized error messages and rethrow exceptions with generic
hints (no sensitive details)
4. **Keep backward compatibility**
- No breaking changes to existing decryption logic
- All fixes are MINOR severity and non-blocking for core functionality
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
