onceMisery commented on PR #10605: URL: https://github.com/apache/seatunnel/pull/10605#issuecomment-4073555862
@DanielCarter-stack Thank you very much for your review comments. I have a different opinion on Issue 1. ## Issue 1: PulsarPartitionSplit serialization compatibility issue ### Actual Situation: The design document (Section 8.2) explicitly requires keeping serialVersionUID unchanged. PulsarSplitEnumeratorState only stores Set<TopicPartition>, not PulsarPartitionSplit. It is impossible to check the tablePath of splits during the restoreEnumerator() phase. Correct Compatibility Handling: ✅ Keep serialVersionUID unchanged (compliant with the design document). ✅ Add a new @Nullable tablePath field (automatically handled as null by Java serialization). ✅ The Reader layer already has fallback logic to handle null tablePath. ✅ Single-table mode can be restored from old checkpoints. ✅ Multi-table mode is a new feature with no old checkpoint issues. ### Conclusion: The core concern of Issue 1 (compatibility) has been properly addressed in the original implementation. No modification to serialVersionUID is required. ## BTW I have fixed all the other issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
