DanielLeens commented on PR #10853: URL: https://github.com/apache/seatunnel/pull/10853#issuecomment-4407243741
Thanks, that additional constraint helps. If the ASF allowlist only accepts the SHA behind `v4.3.1`, then my earlier technical point still stands, but the framing changes: this is no longer a pure behavior-preserving pin of the existing version, it becomes an explicit action upgrade to `v4.3.1` using the approved SHA. There is still no new commit after Daniel's latest review, so I am treating this as a reply-only follow-up rather than a fresh full re-review. From Daniel's side, either path is reasonable: 1. keep the approved `v4.3.1` SHA, but make the upgrade intent explicit in the PR title/body; 2. or request allowlist approval for the exact `v4.3.0` SHA if the goal is a strict same-version pin. Once the branch or PR framing reflects the chosen path, I am happy to re-review the updated state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
