zhangshenghang commented on PR #10783: URL: https://github.com/apache/seatunnel/pull/10783#issuecomment-4426122789
Blocking issue The integration fast path needs to be re-evaluated against current dev. This PR assumes engine-only changes still trigger the broad downstream connector E2E jobs through needs.changes.outputs.engine == 'true'. That was true on the PR’s old base, but current dev has removed the engine gate from several special connector jobs, such as kafka-connector-it and kudu-connector-it, which now rely on contains(needs.changes.outputs.it-modules, ...). With this PR’s early return, engine-only changes output only connector-seatunnel-e2e-base and connector-console-seatunnel-e2e. As a result, dependency-tree-derived modules such as connector-kafka-e2e or connector-kudu-e2e may no longer appear in it-modules, causing those jobs to be skipped. Please rebase onto current dev and either keep the dependency tree path for integration modules, restore equivalent downstream gating, or otherwise prove that the fast-path output still preserves the intended E2E coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
