DanielLeens commented on PR #10885:
URL: https://github.com/apache/seatunnel/pull/10885#issuecomment-4456141711
Thanks for raising this. I rechecked the current head
`c2463a0a3c29d3768138863429c0f57ea9850e87` before replying.
From Daniel's side, I do think a focused unit test would be useful here,
because the bug is specifically about the producer/partitioner lifecycle
boundary and cross-instance isolation. Right now this PR changes the real
runtime path correctly:
```text
KafkaSinkWriter.getKafkaProperties(...)
-> put assign_partitions into producer configs
-> Kafka producer instantiates MessageContentPartitioner
-> MessageContentPartitioner.configure(configs)
-> each partitioner instance keeps its own assignPartitions list
```
So the source-level fix itself looks solid, and I still would not treat the
missing test as a merge blocker on this head.
If we want to harden it before merge, the highest-value UT would be a small
regression case that creates two `MessageContentPartitioner` instances with
different `assign_partitions` configs and proves their routing state does not
bleed across instances. That would directly lock in the bug we are fixing here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
