puneetdixit200 opened a new pull request, #10893:
URL: https://github.com/apache/seatunnel/pull/10893
### Purpose of this pull request
Fixes #10870.
This PR fixes Milvus sink target collection resolution when users configure
`collection_name`. The Milvus sink now treats `collection_name` as a deprecated
compatibility alias for `collection`, while keeping `collection` as the
canonical option and giving it precedence when both are set.
It also makes the Milvus sink factory safe for the `FactoryUtil` fallback
probe by allowing `createSink(null)` without emitting a misleading NPE, and
expands the Milvus sink option rule to include the sink options already used by
the connector.
### Does this PR introduce _any_ user-facing change?
Yes.
Users can now use the existing reported `collection_name` config key as a
compatibility alias, though `collection` remains the documented and preferred
key. The Milvus sink docs now explicitly document `collection`.
### How was this patch tested?
- Added `MilvusSinkFactoryTest`.
- Verified red gate before the fix:
- `collection_name` incorrectly resolved to upstream table `raw_data`
- `createSink(null)` threw `NullPointerException`
- Milvus sink option rule missed sink options
- `./mvnw.cmd -pl seatunnel-connectors-v2\connector-milvus
-Dtest=MilvusSinkFactoryTest test`
- `./mvnw.cmd -pl seatunnel-connectors-v2\connector-milvus -DskipITs test`
- `./mvnw.cmd spotless:check`
Note: `./mvnw.cmd -pl seatunnel-connectors-v2\connector-milvus -am -DskipITs
test` was attempted but failed before reaching Milvus in
`seatunnel-config-shade` due missing shaded Typesafe Config symbols in the
upstream dependency build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
