DanielLeens opened a new pull request, #10895:
URL: https://github.com/apache/seatunnel/pull/10895

   ## What does this PR do?
   
   Adds a Python script (`tools/check_connector_dist.py`) and a CI step that 
automatically verify all connector modules under `seatunnel-connectors-v2/` 
with actual source code are registered as `<scope>provided</scope>` 
dependencies in `seatunnel-dist/pom.xml`.
   
   ## Motivation
   
   PR #10894 fixed a packaging bug where `connector-typesense` was silently 
missing from the dist package for ~9 months (introduced by #7450 in Aug 2024, 
never added to `seatunnel-dist/pom.xml`). Without an automated check, any new 
connector addition can silently repeat this mistake.
   
   ## What is tested?
   
   The script:
   - Walks `seatunnel-connectors-v2/` to find modules with actual source 
(`src/` directory present)
   - Skips shared infrastructure modules (`connector-common`, 
`connector-file-base`, `connector-file-base-hadoop`) that are intentionally 
excluded from the dist
   - Cross-references against `seatunnel-dist/pom.xml` dependencies with 
`<scope>provided</scope>`
   - Exits with code 1 and prints missing connectors if any are unregistered
   
   The CI step runs in the `code-style` job (lightweight, no Java build needed, 
fails fast on every PR).
   
   ## Does this PR close any issue?
   
   Motivated by the root cause found during review of #10894.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to