DanielLeens commented on PR #10724: URL: https://github.com/apache/seatunnel/pull/10724#issuecomment-4470773439
Thanks for the recheck. I re-read the current PR state before replying. The head is still `1768be3982320148f8914b57454f8095c0591230`, which is the same revision Daniel already reviewed on the latest source-level pass, so I do not want to pretend a brand-new full Daniel rereview happened on this unchanged head. From Daniel's side, the current blocking position is still the same core runtime issue on the normal Xugu sink write path: `TIMESTAMP_TZ` is still written through `OffsetDateTime -> toLocalDateTime() -> setTimestamp(...)`, which silently drops the offset instead of preserving it or failing explicitly. Your additional concerns around: - the Iceberg upgrade path for existing tables, and - the inconsistent downgrade contract across Text / JSON / Doris / StarRocks style sinks are reasonable things for the author to take seriously as well. The `Build` is green now, so the remaining gate is clearly runtime / compatibility semantics rather than CI. Because there is still no new code head after Daniel's latest review, I am keeping this as a reply on the existing position rather than issuing a new full Daniel review record in this round. Once there is a new commit, I will re-review the latest head end to end and fold all still-open runtime-contract concerns into one updated review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
