nzw921rx opened a new pull request, #10898:
URL: https://github.com/apache/seatunnel/pull/10898
### Purpose of this pull request
`ConnectorSpecificationCheckTest` (in `seatunnel-dist`) requires sinks that
implement `SupportMultiTableSink` to declare
`SinkConnectorCommonOptions.MULTI_TABLE_SINK_REPLICA` in `optionRule()`
optional options. `TypesenseSinkFactory` did not, which failed CI once
`connector-typesense` is picked up by the dist check. **Change:** add that
optional to `TypesenseSinkFactory#optionRule()`, consistent with other sinks.
**CI failure before fix**
(`ConnectorSpecificationCheckTest#testAllConnectorImplementFactoryWithUpToDateMethod`):
```
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0
org.opentest4j.AssertionFailedError: Please add
`SinkCommonOptions.MULTI_TABLE_SINK_REPLICA` optional into the `optionRule`
method optional of `TypesenseSinkFactory` ==> expected: <true> but was: <false>
at
org.apache.seatunnel.api.connector.ConnectorSpecificationCheckTest.checkSupportMultiTableSink(ConnectorSpecificationCheckTest.java:185)
at
org.apache.seatunnel.api.connector.ConnectorSpecificationCheckTest.testAllConnectorImplementFactoryWithUpToDateMethod(ConnectorSpecificationCheckTest.java:172)
```
### Does this PR introduce _any_ user-facing change?
No. This satisfies the specification check only; `MULTI_TABLE_SINK_REPLICA`
is an existing shared optional; default behavior is unchanged unless you rely
on that option like other sinks.
### How was this patch tested?
- `./mvnw -B -T 1 -Dlicense.skipAddThirdParty=true -Dskip.ui=false
--no-snapshot-updates test -DskipUT=false -DskipIT=true -pl :seatunnel-dist`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
